[Doctrine/Events] Fix bad argument name in example #17380
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@neghmurken thanks a lot for this contribution. Before merging it, I looked in the docs and found that our variable naming is very inconsistent in examples like this. That's why I've opened an issue to discuss about this (#17381) and I'm closing this PR so we can later fix all variables starting from 4.4 branch and up. Thanks! |
|
@javiereguiluz I think we should reopen here nonetheless as the code example as is right now is not runnable (see the mismatch of the argument name and the variable being used inside the method body). |
xabbuh
approved these changes
Oct 28, 2022
OskarStark
approved these changes
Oct 28, 2022
|
Thank you Pierre. |
OskarStark
added a commit
that referenced
this pull request
Oct 28, 2022
…murken) This PR was submitted for the 6.1 branch but it was merged into the 5.4 branch instead. Discussion ---------- [Doctrine/Events] Fix bad argument name in example The ContainerConfigurator variable name used in method argument did not match the name used in the method body <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- bdb7399 [Doctrine/Events] Fix bad argument name in example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ContainerConfigurator variable name used in method argument did not match the name used in the method body