8000 Use a better name than "class Foo" by BafS · Pull Request #16634 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Use a better name than "class Foo" #16634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2022
Merged

Use a better name than "class Foo" #16634

merged 1 commit into from
Mar 24, 2022

Conversation

BafS
Copy link
Contributor
@BafS BafS commented Mar 22, 2022

It took me a while to figure out what represent class Foo

@carsonbot carsonbot added this to the 5.4 milestone Mar 22, 2022
@wouterj wouterj modified the milestones: 5.4, 4.4 Mar 22, 2022
94noni
94noni reviewed Mar 22, 2022
View reviewed changes
components/event_dispatcher.rst
@@ -491,9 +491,9 @@ is dispatched, are passed as arguments to the listener::
use Symfony\Contracts\EventDispatcher\Event;
use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;

class Foo
class MySubscriber
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not MyListener ? in ref to the above are passed as arguments to the listener

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both work for me but maybe we should update this sentence too: are passed as arguments to the listener/subscriber

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the end I changed this for MyListener and didn't add "subscriber" to the text description because this section only mentions listeners (there are other sections in this article that talk about subscribers). Cheers!

@BafS @javiereguiluz
Use a better name than "class Foo"
1b8d52d 
It took me a while to figure out what represent `class Foo`
@javiereguiluz javiereguiluz changed the base branch from 5.4 to 4.4 March 24, 2022 15:13
@javiereguiluz javiereguiluz merged commit 1dcc3cd into symfony:4.4 Mar 24, 2022
@javiereguiluz
Copy link
Member

Thanks Fabien!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

@94noni 94noni 94noni left review comments

@wouterj wouterj wouterj approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

@OskarStark OskarStark Awaiting requested review from OskarStark

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@BafS @javiereguiluz @wouterj @94noni @carsonbot
0