8000 [OptionsResolver] Fix code sample for chaining by JakeFr · Pull Request #15723 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[OptionsResolver] Fix code sample for chaining #15723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[OptionsResolver] Fix code sample for chaining #15723

wants to merge 3 commits into from

Conversation

JakeFr
Copy link
Contributor
@JakeFr JakeFr commented Aug 17, 2021

OptionConfigurator::allowedValues is a variadic function.

wouterj and others added 2 commits April 26, 2021 11:18
@carsonbot
Copy link
Collaborator

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 4.4, 5.3, 5.4, 6.0.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 5.1 milestone Aug 17, 2021
@JakeFr JakeFr changed the base branch from 5.1 to 5.3 August 22, 2021 13:29
@javiereguiluz
Copy link
Member

Good catch, thanks @JakeFr.

javiereguiluz added a commit that referenced this pull request Sep 22, 2021
@javiereguiluz
minor #15723 [OptionsResolver] Fix code sample for chaining (wouterj,…
0e346f7 
… JakeFr)

This PR was merged into the 5.3 branch.

Discussion
----------

[OptionsResolver] Fix code sample for chaining

OptionConfigurator::allowedValues is a variadic function.

Commits
-------

895b840 Update notifier.rst
65a32a6 [OptionsResolver] Fix code sample for chaining
@javiereguiluz
Copy link
Member

I've closed this pull request manually because the tool we use to merge things didn't close it automatically, as usual. But don't worry, your changes were successfully merged! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OptionsResolver Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@JakeFr @carsonbot @javiereguiluz @wouterj
0