10000 Document the option to map PHP errors to log levels by javiereguiluz · Pull Request #15461 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Document the option to map PHP errors to log levels #15461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2021
Merged

Document the option to map PHP errors to log levels #15461

merged 1 commit into from
Jun 25, 2021

Conversation

javiereguiluz
Copy link
Member

Fixes #15451.

I need help reviewing the PHP config format. Maybe @Nyholm can help us here? Thanks!

@javiereguiluz javiereguiluz added this to the 5.3 milestone Jun 23, 2021
@Nyholm
Copy link
Member
Nyholm commented Jun 23, 2021

It looks good.

The Code Blocks job does not complain so it all should be correct syntax and runnable.

Im not sure about the Yaml error. I've never used PHP constants in yaml before.

@javiereguiluz
Copy link
Member Author

Thanks Tobias!

ogizanagi
ogizanagi approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor
@ogizanagi ogizanagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks Javier

@javiereguiluz javiereguiluz merged commit 420c2a4 into symfony:5.3 Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogizanagi ogizanagi ogizanagi approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
4 participants
@javiereguiluz @Nyholm @ogizanagi @carsonbot
0