8000 [Validator] Use constant instead of magic string by wkania · Pull Request #14871 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Use constant instead of magic string #14871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2021
Merged

[Validator] Use constant instead of magic string #14871

merged 1 commit into from
Jan 23, 2021

Conversation

wkania
Copy link
Contributor
@wkania wkania commented Jan 23, 2021

Related to the comment.

@wkania wkania requested a review from xabbuh as a code owner January 23, 2021 10:22
@javiereguiluz javiereguiluz added this to the 5.2 milestone Jan 23, 2021
@javiereguiluz javiereguiluz changed the base branch from 5.x to 5.2 January 23, 2021 13:37
@javiereguiluz
Copy link
Member

Thank you @wkania.

@javiereguiluz javiereguiluz merged commit d9dc93a into symfony:5.2 Jan 23, 2021
@wkania wkania deleted the patch-9 branch January 31, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Status: Reviewed Validator
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@wkania @javiereguiluz @OskarStark @carsonbot
0