10000 [Serializer] Update serializer.rst by souhail-5 · Pull Request #14868 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

[Serializer] Update serializer.rst #14868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Conversation

souhail-5
Copy link
Contributor
@souhail-5 souhail-5 commented Jan 22, 2021

Update CsvEncoder's default values.

Not really sure for the empty string mention.

@carsonbot carsonbot changed the title Update serializer.rst [Serializer] Update serializer.rst Jan 22, 2021
@javiereguiluz javiereguiluz added this to the 4.4 milestone Jan 22, 2021
Update CsvEncoder's default values
@javiereguiluz
Copy link
Member

Thanks Souhail! I like your idea of showing "empty string" explicitly because it's easy to understand. Thanks!

@javiereguiluz javiereguiluz merged commit c6f45d8 into symfony:4.4 Jan 22, 2021
@souhail-5 souhail-5 deleted the patch-2 branch January 22, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0