8000 Update column type for MySQL sessions table by beejaz · Pull Request #13767 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Update column type for MySQL sessions table #13767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update column type for MySQL sessions table #13767

wants to merge 1 commit into from

Conversation

beejaz
Copy link
Contributor
@beejaz beejaz commented Jun 7, 2020

This page hasnt been updated with this fix #12641 for "Preparing the Database to Store Sessions" on MySQL db, causing error:

SQLSTATE[22003]: Numeric value out of range: 1264 Out of range value for column 'sess_lifetime' at row 1

Its fixed by changing MEDIUMINT to INTEGER UNSIGNED for sess_lifetime column.

Its the same miss in 4.4, 5.0 and 5.1

@javiereguiluz
Copy link
Member

Closing in favor of #13765.

@beejaz thanks for this contribution. However, it's not necessary because you did the same change in another pull request that targets 4.4, a lower branch. Because of how Symfony Docs maintainers merge contributions, you only need to submit a pull request to fix the issue in the lowest maintained branch that contains the error (4.4 in this case). Later, when merging things, mergers take care of merging the same change in all supported branches up to master. That's why we're closing this and keeping only the pull request targeted at 4.4 branch. Thanks!

This was referenced Jun 7, 2020
Closed
Closed
@beejaz
Copy link
Contributor Author
beejaz commented Jun 9, 2020

Thanks and sorry for missunderstanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beejaz @javiereguiluz @carsonbot
0