8000 [Security] Added docs about the authenticator-based Security system by wouterj · Pull Request #13704 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Security] Added docs about the authenticator-based Security system #13704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2020
Merged

[Security] Added docs about the authenticator-based Security system #13704

merged 1 commit into from
Jun 4, 2020

Conversation

wouterj
Copy link
Member
@wouterj wouterj commented May 25, 2020 •
edited
Loading

As the new system is experimental, I think it's best to not update the main documentation of Security yet (also, the main guide isn't really affected by the new system - except from the removal of anonymous). This can be done once we deprecate the old system (in 5.3 or 5.4).

I do however think we should link more to this article, as I want to push people to use it. What do you think about adding a .. tip:: in:

  • security/guard_authentication & security/form_login_setup
  • security/custom_authentication_provider (replace the one to Guard)
  • security (at the start, as a "hey, please start by doing enable_authenticator_manager: true")

Fixes #13575

@wouterj wouterj added this to the 5.1 milestone May 25, 2020
@wouterj wouterj requested a review from weaverryan May 25, 2020 11:44
wouterj
wouterj commented May 25, 2020
View reviewed changes
@wouterj wouterj force-pushed the issue-13375/authenticators-security branch from e4d771b to 2add95e Compare May 25, 2020 11:51
noniagriconomie
noniagriconomie reviewed May 25, 2020
View reviewed changes
jmsche
jmsche reviewed May 26, 2020
View reviewed changes
@wouterj wouterj force-pushed the issue-13375/authenticators-security branch 2 times, most recently from 0a3f8c7 to 2b3016f Compare May 26, 2020 22:52
javiereguiluz
javiereguiluz approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouter, thanks for contributing these docs. They are easy to follow even if you don't know much about security.

pskt
pskt reviewed Jun 3, 2020
View reviewed changes
@wouterj wouterj force-pushed the issue-13375/authenticators-security branch from 2b3016f to b4e45f2 Compare June 3, 2020 13:03
@wouterj
Copy link
Member Author
wouterj commented Jun 3, 2020

Thanks for the review. I've fixed the comments and also added some references to the article from other places in the docs (as proposed in the description).

weaverryan
weaverryan reviewed Jun 3, 2020
View reviewed changes
Copy link
Member
@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff - pretty sweet :)

@wouterj wouterj force-pushed the issue-13375/authenticators-security branch from b4e45f2 to 9b07706 Compare June 3, 2020 14:55
@jrushlow jrushlow mentioned this pull request Jun 4, 2020
Closed
@wouterj wouterj force-pushed the issue-13375/authenticators-security branch from 9b07706 to e15f77a Compare June 4, 2020 15:41
@wouterj wouterj force-pushed the issue-13375/authenticators-security branch from e15f77a to bdb5271 Compare June 4, 2020 15:46
@wouterj wouterj merged commit ce95d60 into symfony:5.1 Jun 4, 2020
@wouterj wouterj deleted the issue-13375/authenticators-security branch June 4, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan left review comments

@pskt pskt pskt left review comments

@jmsche jmsche jmsche left review comments

@noniagriconomie noniagriconomie noniagriconomie left review comments

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
7 participants
@wouterj @javiereguiluz @weaverryan @pskt @jmsche @noniagriconomie @carsonbot
0