8000 [Form] Added docs for alpha3 option in CountryType and LanguageType by creiner · Pull Request #12441 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Form] Added docs for alpha3 option in CountryType and LanguageType #12441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2019
Merged

[Form] Added docs for alpha3 option in CountryType and LanguageType #12441

merged 1 commit into from
Oct 9, 2019

Conversation

creiner
Copy link
Contributor
@creiner creiner commented Oct 7, 2019 •
edited by javiereguiluz
Loading

Fixes #12415. Here are the documentation parts for the PR:
symfony/symfony#33791
Hope I didn't make any mistakes.. :-)

@creiner creiner requested a review from xabbuh as a code owner October 7, 2019 15:27
@xabbuh xabbuh added this to the 4.4 milestone Oct 7, 2019
OskarStark
OskarStark requested changes Oct 8, 2019
View reviewed changes
@javiereguiluz javiereguiluz force-pushed the added-alpha3-countrytype-languagetype-doc branch from e91d247 to 377d71c Compare October 9, 2019 07:11
javiereguiluz added a commit that referenced this pull request Oct 9, 2019
@javiereguiluz
minor #12441 [Form] Added docs for alpha3 option in CountryType and L…
8b33bc5 
…anguageType (creiner)

This PR was squashed before being merged into the 4.4 branch (closes #12441).

Discussion
----------

[Form] Added docs for alpha3 option in CountryType and LanguageType

Here are the documentation parts for the PR:
symfony/symfony#33791
Hope I didn't make any mistakes.. :-)

Commits
-------

377d71c [Form] Added docs for alpha3 option in CountryType and LanguageType
@javiereguiluz javiereguiluz merged commit 377d71c into symfony:4.4 Oct 9, 2019
@javiereguiluz
Copy link
Member

@creiner thanks a lot for this contribution! You did it great ... but we added some minor tweaks while merging to add the versionadded:: 4.4 directive and add some links to the Wikipedia lists of 2-letter and 3-letter codes.

Congrats on your first Symfony Docs contribution!

@javiereguiluz javiereguiluz mentioned this pull request Oct 9, 2019
Closed
@ro0NL
Copy link
Contributor
ro0NL commented Oct 10, 2019

@javiereguiluz alpha3 option is currently documented for CountryType (https://symfony.com/doc/4.4/components/intl.html#country-names) but is wrong for LanguageType which uses ISO 639 (https://symfony.com/doc/4.4/components/intl.html#language-and-script-names)

so https://symfony.com/doc/4.4/reference/forms/types/language.html#alpha3 is wrong currently

@javiereguiluz
Copy link
Member

I'm sorry but I don't understand your comment. This is about the Form component ... but you are linking to Intl, so I'm confused:

Should this be documented only in Intl but not in Form? Only in Form but not in Intl? In both but differently? Thanks.

@ro0NL
Copy link
Contributor
ro0NL commented Oct 10, 2019

i mean both LanguageType and CountryType refer to ISO 3166, whereas LanguageType should refer ISO 639

@creiner
Copy link
Contributor Author
creiner commented Oct 11, 2019

So the alpha3 part shout be changed to ISO 639 for language type.
I would then remove the include and put it directly into the form type, since its no duplication any more.
Should I change it in this PR or should I open a new one?

@javiereguiluz
Copy link
Member

@creiner this PR is already merged, so a new one should be created. I'm sorry!

@creiner creiner mentioned this pull request Oct 11, 2019
Merged
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Oct 11, 2019
@javiereguiluz
minor symfony#12463 [Form] Changed the ISO Code and example for Langu…
3eb8008 
…ageType (creiner)

This PR was merged into the 4.4 branch.

Discussion
----------

[Form] Changed the ISO Code and example for LanguageType

As discussed in the previous PR here:
symfony#12441

Commits
-------

4b76e73 Changed the ISO Code and example for LanguageType
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@creiner @javiereguiluz @ro0NL @OskarStark @xabbuh @carsonbot
0