From cf8fd76720f3bf036762e65125296c2c8f58e262 Mon Sep 17 00:00:00 2001 From: Ivan Date: Mon, 29 Jul 2019 12:40:43 +0300 Subject: [PATCH] Fix rules according to the current release process I read rules and think that I can extend non-internal classes and not test classes. Only security fixes can cause BC. But this PR https://github.com/symfony/symfony/pull/20487 is not Security fix and break my code. I extended `ProgressBar` and didn't see any troubles. All works fine. After upgrade from 3.2 to 3.3 I got BC. To avoid future troubles it is better to not extend classes. Developers should know that not only security fixes can break the code. --- contributing/code/bc.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/code/bc.rst b/contributing/code/bc.rst index 30cffd8eae8..1d1f0a98ada 100644 --- a/contributing/code/bc.rst +++ b/contributing/code/bc.rst @@ -110,7 +110,7 @@ covered by our backward compatibility promise: +-----------------------------------------------+-----------------------------+ | Create a new instance | Yes | +-----------------------------------------------+-----------------------------+ -| Extend the class | Yes | +| Extend the class | No | +-----------------------------------------------+-----------------------------+ | Access a public property | Yes | +-----------------------------------------------+-----------------------------+