8000 Fix new instance of a class name by peaceant · Pull Request #11830 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Fix new instance of a class name #11830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2019
Merged

Fix new instance of a class name #11830

merged 1 commit into from
Jun 27, 2019

Conversation

peaceant
Copy link
Contributor

Fix for #11824

@OskarStark
Copy link
Contributor
OskarStark commented Jun 26, 2019 •
edited
Loading

cc @Nyholm, but I think this fix is correct

Nyholm
Nyholm approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the ping.

Yes. That is correct. Thank you for improving the docs!

@javiereguiluz javiereguiluz changed the base branch from 4.3 to 3.4 June 27, 2019 06:37
@javiereguiluz javiereguiluz merged commit c08a0e3 into symfony:3.4 Jun 27, 2019
javiereguiluz added a commit that referenced this pull request Jun 27, 2019
@javiereguiluz
minor #11830 Fix new instance of a class name (peaceant)
297ae27 
This PR was submitted for the 4.3 branch but it was merged into the 3.4 branch instead (closes #11830).

Discussion
----------

Fix new instance of a class name

Fix for #11824

Commits
-------

c08a0e3 Fix new instance of a class name
@javiereguiluz
Copy link
Member

@peaceant thanks for this fix (we merged it in 3.4 branch) and congrats on your first Symfony Docs contribution!

@javiereguiluz javiereguiluz mentioned this pull request Jun 27, 2019
Closed
@Nyholm
Copy link
Member
Nyholm commented Jun 27, 2019

Wohoo! =)

@Art4
Copy link
Contributor
Art4 commented Jul 24, 2019 •
edited
Loading

@javiereguiluz Why have you changed the merging branch from 4.3 to 3.4?

There is no Symfony\Component\Cache\**Simple\Psr16Adapter**, but the Symfony\Component\Cache\**Adapter\Psr16Adapter** or Symfony\Component\Cache\**Simple\Psr6Cache**.

The Symfony\Component\Cache\**Adapter\Psr16Adapter** was introduced in 4.3, see symfony/symfony#29236. Hence the docs is now wrong.

class 3.4 4.0 4.1 4.2 4.3 4.4
Symfony\Component\Cache\Adapter\Psr16Adapter ❌ ❌ ❌ ❌ ✔️ ✔️
Symfony\Component\Cache\Simple\Psr6Cache ✔️ ✔️ ✔️ ✔️ ⚠️ ⚠️

@Art4 Art4 mentioned this pull request Jul 24, 2019
Merged
javiereguiluz added a commit that referenced this pull request Jul 26, 2019
@javiereguiluz
minor #12022 Fix Psr6Cache classname for 3.4 and 4.2 (Art4)
bd23e4c 
This PR was merged into the 3.4 branch.

Discussion
----------

Fix Psr6Cache classname for 3.4 and 4.2

This PR will fix a wrong class name that was added in #11830.

This PR affects only the branches 3.4 and 4.2.

In 4.3 the class was deprecated and moved to `Symfony\Component\Cache\Psr16Cache`, so the branches 4.3 and 4.4 are not affected.

Commits
-------

595ed5b Fix classname for Psr6Cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
Cache Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@peaceant @OskarStark @javiereguiluz @Nyholm @Art4 @carsonbot
0