8000 Documented the deprecation of the Templating component by javiereguiluz · Pull Request #11231 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Documented the deprecation of the Templating component #11231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000
Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Documented the deprecation of the Templating component #11231

wants to merge 3 commits into from

Conversation

javiereguiluz
Copy link
Member

Documents symfony/symfony#21035 but there are some things I'm not sure about. Please, review.

@javiereguiluz javiereguiluz added this to the 4.3 milestone Mar 27, 2019
wouterj
wouterj requested changes Apr 6, 2019
View reviewed changes
Copy link
Member
@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with all changes except the form theming, which I commented on. Did you have more things you were unsure about?

@wouterj wouterj removed the On hold label Apr 6, 2019
@javiereguiluz javiereguiluz changed the title (WIP) Documented the deprecation of the Templating component Documented the deprecation of the Templating component Apr 8, 2019
@javiereguiluz
Copy link
Member Author

Now that symfony/symfony#30959 has been merged, this is now ready for the final review.

wouterj
wouterj approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member
@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Tobion Tobion mentioned this pull request Jun 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@OskarStark OskarStark OskarStark approved these changes

@yceruto yceruto yceruto approved these changes

@Simperfit Simperfit Simperfit approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Templating
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
6 participants
@javiereguiluz @wouterj @OskarStark @yceruto @Simperfit @carsonbot
0