RM: Sentence about extending the Request class #10628
Conversation
Extending the Request class is not recommended: symfony/symfony#29059
|
@andreaslarssen thanks for changing this. As discussed in the related pull request, extending the Request class is not something we want to support/promote, so let's remove this. We've merged it in 3.4 branch and will merge it up in the other branches automatically. Also, congrats on your first Symfony Docs contribution! |
…arssen) This PR was submitted for the 4.1 branch but it was merged into the 3.4 branch instead (closes #10628). Discussion ---------- RM: Sentence about extending the Request class Extending the Request class is not recommended: symfony/symfony#29059 Commits ------- a23feff RM: Sentence about extending the Request class
|
@javiereguiluz. Thanks! Wasn't sure about what branch to merge this in. |
|
@andreaslarssen yes, picking the right branch is sometimes difficult. The recommended reasoning is: "pick the oldest maintained branch that contains the bug/problem/issue". And this is where the list of maintained branches is continuously updated: https://symfony.com/roadmap#maintained-symfony-branches |
|
@javiereguiluz: thanks again. What made me unsure was that @fabpot said in symfony/symfony#29059 that the sub_class check in |
Extending the Request class is not recommended:
symfony/symfony#29059