8000 Also requiring annotations so they can be used by weaverryan · Pull Request #10174 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

Also requiring annotations so they can be used #10174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2018

Conversation

weaverryan
Copy link
Member

It's an edge case, as most people use the website-skeleton or install the annotations (SensioFWExtra) package, but just in case, the user does need doctrine/annotations in order to support using annotations with validation - https://github.com/symfony/symfony/blob/f96753b9ab497a42f7a76188e2de4911b50f5407/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php#L744

Cheers!

@weaverryan weaverryan force-pushed the add-annotations-validation branch from b5a5dcc to 89610c7 Compare August 10, 2018 16:46
@xabbuh xabbuh added this to the 4.1 milestone Aug 13, 2018
@xabbuh
Copy link
Member
xabbuh commented Aug 21, 2018

Thank you Ryan.

@xabbuh xabbuh merged commit 89610c7 into symfony:4.1 Aug 21, 2018
xabbuh added a commit that referenced this pull request Aug 21, 2018
This PR was merged into the 4.1 branch.

Discussion
----------

Also requiring annotations so they can be used

It's an edge case, as most people use the `website-skeleton` or install the `annotations` (SensioFWExtra) package, but just in case, the user *does* need `doctrine/annotations` in order to support using annotations with validation - https://github.com/symfony/symfony/blob/f96753b9ab497a42f7a76188e2de4911b50f5407/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php#L744

Cheers!

Commits
-------

89610c7 Also requiring annotations so they can be used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0