8000 [Routing] Trailing Slash article should be changed for 4.1 · Issue #9761 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Routing] Trailing Slash article should be changed for 4.1 #9761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vudaltsov opened this issue May 11, 2018 · 3 comments
Closed

[Routing] Trailing Slash article should be changed for 4.1 #9761

vudaltsov opened this issue May 11, 2018 · 3 comments
Labels
Routing
Milestone
4.1

Comments

@vudaltsov
Copy link
Contributor

It looks like since 4.1 and symfony/symfony#26283 article https://symfony.com/doc/current/routing/redirect_trailing_slash.html is no longer needed.

Besides implementing such a controller in 4.1 will cause infinite redirect from no trailing slash to trailing slash and back for non matching urls.
@javiereguiluz
Copy link
Member

You are right! However, this change is already done. In 4.1 this article no longer exists: https://symfony.com/doc/4.1/routing/redirect_trailing_slash.html Closing then as fixed. Thanks!

@xabbuh xabbuh added the Routing label May 14, 2018
@xabbuh xabbuh added this to the 4.1 milestone May 14, 2018
@xabbuh
Copy link
Member
xabbuh commented May 14, 2018

For the records, the changes was made in #9385.

@vudaltsov
Copy link
Contributor Author
vudaltsov commented May 14, 2018 •
edited
Loading

I think it would be nice to attract community's attention to this somehow. Recently I updated one of my projects to 4.1 beta for test and for about an hour couldn't understand why I had infinite redirects on favicon.ico (which didn't exist).

Only after thorough analysis I realized I had to remove my redirect controller from routes.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Routing
Projects
None yet
Milestone
4.1
Development

No branches or pull requests
3 participants
@javiereguiluz @xabbuh @vudaltsov
0