8000 Wrong deprecation message for ClassLoader · Issue #7615 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Wrong deprecation message for ClassLoader #7615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Mar 13, 2017 · 3 comments
Closed

Wrong deprecation message for ClassLoader #7615

javiereguiluz opened this issue Mar 13, 2017 · 3 comments
Labels
bug good first issue Ideal for your first contribution! (some Symfony experience may be required) Status: Needs Review

Comments

@javiereguiluz
Copy link
Member

In the 3.2 version (http://symfony.com/doc/current/components/class_loader.html) we can see a warning saying that the component is deprecated in 3.3.

We should remove it and keep it only for 3.3 version (http://symfony.com/doc/master/components/class_loader.html).
@javiereguiluz javiereguiluz added bug good first issue Ideal for your first contribution! (some Symfony experience may be required) labels Mar 13, 2017
@xabbuh
Copy link
Member
xabbuh commented Mar 13, 2017

I deliberately merged #7383 into the 2.7 branch as I wanted to make this deprecation as visible as possible. IMO there is no good reason why someone should start a new project based on the ClassLoader component even with Symfony 2.7 or 2.8. So why shouldn't we make everybody aware of the deprecation as soon as possible (this is not like with other deprecations where you would really need newer versions of a component to be able to use the non-deprecated approach for a particular feature)?

@HeahDude
Copy link
Contributor

I tend to agree with @xabbuh, this is more about the PHP version used and OPCache being available from 5.5.

Maybe we should either move it in 3.3 only or add a sentence to explain why this deprecation is not like others for consistency?

@javiereguiluz
Copy link
Member Author

OK then. Let's close it! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue Ideal for your first contribution! (some Symfony experience may be required) Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@javiereguiluz @xabbuh @HeahDude @carsonbot
0