8000 Mistake in validation doc · Issue #7412 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Mistake in validation doc #7412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
remi-blaise opened this issue Jan 25, 2017 · 2 comments
Closed

Mistake in validation doc #7412

remi-blaise opened this issue Jan 25, 2017 · 2 comments
Assignees
@javiereguiluz
Labels
hasPR A Pull Request has already been submitted for this issue. Validator

Comments

@remi-blaise
Copy link

Hello!

I think there is an error in the doc:
https://symfony.com/doc/current/validation.html#configuration

But the actual default config is:

framework:
    validation:      { enable_annotations: true }

Cheers ;)
@ogizanagi
Copy link
Contributor
ogizanagi commented Jan 25, 2017 •
edited
Loading

Actually, this is indeed the "default" config provided in the standard edition, but enable_annotations is false be default, as described in the FrameworkBundle Configuration class :)
(Note this value slightly changes since symfony/symfony#21196 to be guessed wisely.)

@remi-blaise
Copy link
Author

Thanks for the explanations :) This is unclear, maybe it could be noticed in the doc with a sentence like

If you are not using the standard edition, you must explicitly enable annotations...

@javiereguiluz javiereguiluz self-assigned this Apr 3, 2017
@javiereguiluz javiereguiluz added hasPR A Pull Request has already been submitted for this issue. Validator labels Apr 3, 2017
@javiereguiluz javiereguiluz mentioned this issue Apr 3, 2017
Merged
xabbuh added a commit that referenced this issue Apr 15, 2017
@xabbuh
minor #7749 Reword the explanation about enabling validation and anno…
671a124 
…tations (javiereguiluz)

This PR was merged into the 2.7 branch.

Discussion
----------

Reword the explanation about enabling validation and annotations

This fixes #7412.

Commits
-------

fee9949 Reword the explanation about enabling validation and annotations
@xabbuh xabbuh closed this as completed Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javiereguiluz javiereguiluz

Labels
hasPR A Pull Request has already been submitted for this issue. Validator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@javiereguiluz @xabbuh @ogizanagi @remi-blaise
0