8000 Add support for ACL auth in RedisAdapter, for 5.x branch · Issue #19955 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Add support for ACL auth in RedisAdapter, for 5.x branch #19955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
julienloizelet opened this issue Jun 12, 2024 · 1 comment
Closed

Add support for ACL auth in RedisAdapter, for 5.x branch #19955

julienloizelet opened this issue Jun 12, 2024 · 1 comment
Labels
Cache hasPR A Pull Request has already been submitted for this issue.
Milestone
5.4

Comments

@julienloizelet
Copy link

Symfony version(s) affected

5.x

Description

As I'm using symfony/cache:v5 (in a project that requires PHP 7.2, unfortunately), I'm facing this issue.

The Symfony 5 documentation states that it is possible to pass an user/password pair:

redis[s]:[[user]:pass@]?[ip|host|socket[:port]][&params]

I understand, with this comment, that it has been considered as a new feature, and not a fix.

Should it be possible to add this fix also in the 5.x branch ?

If not, I guess the documentation should be updated for clarification.

How to reproduce

Same as symfony/symfony#45305, but with symfony/cache:v5

Possible Solution

Use this patch : symfony/symfony@722830d#diff-38029e8e3e92a47fb8091876d3e8bc7fc61c2fc793cabf842ed933bf6985134c

Additional Context

No response
@xabbuh xabbuh added the Cache label Jun 12, 2024
@xabbuh xabbuh transferred this issue from symfony/symfony Jun 12, 2024
@xabbuh
Copy link
Member
xabbuh commented Jun 12, 2024

@julienloizelet Thanks for creating this bug report. We do indeed have to fix the documentation around this. That's why I have moved your issue in this repository.

@javiereguiluz javiereguiluz added hasPR A Pull Request has already been submitted for this issue. and removed bug Status: Needs Review labels Jun 13, 2024
@javiereguiluz javiereguiluz added this to the 5.4 milestone Jun 13, 2024
@javiereguiluz javiereguiluz mentioned this issue Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cache hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
5.4
Development

No branches or pull requests
4 participants
@javiereguiluz @xabbuh @carsonbot @julienloizelet
0