8000 [HttpFoundation] Cookies Having Independent Partitioned State (CHIPS) · Issue #19027 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] Cookies Having Independent Partitioned State (CHIPS) #19027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue Oct 16, 2023 · 8 comments · Fixed by #19118
Closed

[HttpF 8000 oundation] Cookies Having Independent Partitioned State (CHIPS) #19027

fabpot opened this issue Oct 16, 2023 · 8 comments · Fixed by #19118
Labels
hasPR A Pull Request has already been submitted for this issue. HttpFoundation
Milestone
6.4

Comments

@fabpot
Copy link
Member
fabpot commented Oct 16, 2023
Q A
Feature PR symfony/symfony#52002
PR author(s) @fabricecw
Merged in 6.4

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 6.4 branch in the symfony-docs repository.

Thank you! 😃
@fabpot fabpot added this to the 6.4 milestone Oct 16, 2023
@alexandre-daubois
Copy link
Member

Hi @fabricecw! Congrats on your first PR 👏 Would you like to write the doc for this feature or can I take care of it? 🙂

@fabricecw
Copy link

Hi @alexandre-daubois! I checked the docs and I'm not sure if there is a useful spot to document the new flag. I thought about documenting all flags for cookies, but not sure if this really helps. Glad about any inputs from your side!

@alexandre-daubois
Copy link
Member
alexandre-daubois commented Oct 16, 2023 •
edited
Loading

I would take a look at https://symfony.com/doc/current/components/http_foundation.html#setting-cookies. Then, at the end of this section, I would add something like this :

You can also define a `partitioned cookie`_ thanks to the :method:`Namespace::withPartionned` method::

// Some example

.. versionadded:: 6.4

    The support fort partionned cookies was introduced in Symfony 6.4.

// At the end of doc
.. _`partitioned cookie`: (url to some external doc)

That's how I would do it 🙂

@alexandre-daubois
Copy link
Member
alexandre-daubois commented Oct 16, 2023 •
edited
Loading

I agree that there wouldn't be much added value in documenting all the cookie flags. But as @nicolas-grekas pointed out in your PR, it's an important, new and little-known (for now) change. I personally think that's worth mentioning, at least in a few lines, at this location.

Feel free to ping me in your PR if you want me to have a look at it once it's ready!

@fabricecw
Copy link

Great, thank you! Let me work something out and I would appreciate your feedback.

@javiereguiluz
Copy link
Member

I'm going to publish a "New in Symfony 6.4" post about this early next week. You could use it as inspiration if you want.

@fabricecw
Copy link

Thanks! I'm a bit busy these days but I will address the docs as soon as I can.

@javiereguiluz
Copy link
Member
javiereguiluz commented Oct 23, 2023 •
edited
Loading

Here's the blog post: https://symfony.com/blog/new-in-symfony-6-4-chips-cookies

I'd say in the docs we shouldn't explain at all what these CHIPS cookies are. Just link to good resources like MDN.

No worries Fabrice. There are many active contributors (like @alexandre-daubois for example) and some can take over and document this if needed. Thanks!

@alexandre-daubois alexandre-daubois mentioned this issue Nov 7, 2023
Merged
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. HttpFoundation
Projects
None yet
Milestone
6.4
Development

Successfully merging a pull request may close this issue.

[HttpFoundation] Cookies Having Independent Partitioned State (CHIPS) alexandre-daubois/symfony-docs
6 participants
@fabpot @javiereguiluz @xabbuh @alexandre-daubois @carsonbot @fabricecw
0