8000 [HttpKernel] Remove deprecated code paths · Issue #18491 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] Remove deprecated code paths #18491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-grekas opened this issue Jul 4, 2023 · 1 comment
Closed

[HttpKernel] Remove deprecated code paths #18491

nicolas-grekas opened this issue Jul 4, 2023 · 1 comment
8000
Labels
hasPR A Pull Request has already been submitted for this issue. HttpKernel
Milestone
7.0

Comments

@nicolas-grekas
Copy link
Member
Q A
Feature PR symfony/symfony#50858
PR author(s) @nicolas-grekas
Merged in 7.0

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 7.0 branch in the symfony-docs repository.

Thank you! 😃
@nicolas-grekas nicolas-grekas added this to the 7.0 milestone Jul 4, 2023
@javiereguiluz javiereguiluz mentioned this issue Jul 4, 2023
Merged
@javiereguiluz
Copy link
Member
javiereguiluz commented Jul 4, 2023 •
edited by OskarStark
Loading

@javiereguiluz javiereguiluz mentioned this issue Jul 4, 2023
Merged
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Jul 5, 2023
OskarStark added a commit that referenced this issue Jul 5, 2023
@OskarStark
minor #18496 [FrameworkBundle] Deprecate terminate_on_cache_hit opt…
8914878 
…ion (javiereguiluz)

This PR was merged into the 6.2 branch.

Discussion
----------

[FrameworkBundle] Deprecate `terminate_on_cache_hit` option

It looks strange to add an option in 6.2 and deprecate it in the same version but:

https://github.com/nicolas-grekas/symfony/blob/19940ffcfe9bbae825ca951f1bb4c78a8a84f9ad/src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php#L245

This is needed before working on #18491.

Commits
-------

b7297ec [FrameworkBundle] Deprecate terminate_on_cache_hit option
@OskarStark OskarStark mentioned this issue Jul 5, 2023
Merged
OskarStark added a commit that referenced this issue Jul 5, 2023
@OskarStark
minor #18498 [HttpKernel] Deprecate all occurrences of ArgumentValueR…
2174905 
…esolverInterface (javiereguiluz)

This PR was merged into the 6.2 branch.

Discussion
----------

[HttpKernel] Deprecate all occurrences of ArgumentValueResolverInterface

Needed before working on #18491.

Commits
-------

86ed5fe Deprecate all occurrences of ArgumentValueResolverInterface
javiereguiluz added a commit that referenced this issue Jul 5, 2023
@javiereguiluz
minor #18510 [FrameworkBundle] Remove terminate_on_cache_hit option…
1fc0bed 
… (OskarStark)

This PR was merged into the 7.0 branch.

Discussion
----------

[FrameworkBundle] Remove `terminate_on_cache_hit` option

Refs
*  #18491

Commits
-------

e6f6bbd Remove `terminate_on_cache_hit` option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. HttpKernel
Projects
None yet
Milestone
7.0
Development

No branches or pull requests
4 participants
@javiereguiluz @nicolas-grekas @OskarStark @carsonbot
0