10000 Revert #17299 · Issue #18328 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Revert #17299 #18328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FlyingDR opened this issue May 19, 2023 · 3 comments
Closed

Revert #17299 #18328

FlyingDR opened this issue May 19, 2023 · 3 comments
Labels
Doctrine hasPR A Pull Request has already been submitted for this issue. Messenger

Comments

@FlyingDR
Copy link
Contributor
FlyingDR commented May 19, 2023 •
edited
Loading

According to a description of #17299 and symfony/symfony#37626 (comment) information about manual filtering of the Doctrine migrations table was restored in documentation because it was unclear why it was removed previously.

It was removed because of the implementation of automatic registration of Messenger's table schema in Doctrine schema in symfony/symfony#36655 which is landed in Symfony 5.1.

Because of this, having this tip in the Symfony documentation is not actual and misleading. I would like to propose to revert #17299 to remove it again.
@javiereguiluz
Copy link
Member

To be honest, I don't fully understand your issue. You say that we should remove this tip, but the resources that you linked (like symfony/symfony#37626 (comment)) seem to indicate that we must have that tip.

Could you please elaborate your issue a bit? Thanks!

@FlyingDR
Copy link
Contributor Author

Sure. The tip in #17299 explains how to prevent Doctrine Migrations from removing the Messenger table from the schema. Doctrine's schema tool is unaware of the Messenger's table as it is not part of the application's schema and normally will try to remove it. The provided tip tries to "hide" Messenger's table from the schema tool by filtering it out using a schema filter.

But symfony/symfony#36655 adds support for automatic adding required SQL to the schema. Because of this Doctrine's schema tool will see the Messenger's table SQL as part of the application's schema and will not include table removal in the migration.

Effectively it means that there is no need to hide Messenger's table from the schema tool because it is automatically included in the application's schema. And because of this, the tip has no practical meaning and can be removed.

I submitted this issue several months ago, so I may forget some details of the original intention. It is also possible that I misunderstood something. But at least from the practical point of view Doctrine Migrations does not attempt to remove Mesenger's table nowadays without schema filter from the tip.

@javiereguiluz javiereguiluz mentioned this issue Sep 20, 2023
Merged
@javiereguiluz
Copy link
Member

I now fully understand the issue. @FlyingDR thanks a lot for the detailed description.

We're trying to fix this issue in #18899.

@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Doctrine hasPR A Pull Request has already been submitted for this issue. Messenger
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@javiereguiluz @FlyingDR @xabbuh
0