8000 [Config] Improve the deprecation features by handling package and versi… · Issue #13470 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Config] Improve the deprecation features by handling package and versi… #13470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-grekas opened this issue Apr 1, 2020 · 1 comment · Fixed by #13521
Closed

[Config] Improve the deprecation features by handling package and versi… #13470

nicolas-grekas opened this issue Apr 1, 2020 · 1 comment · Fixed by #13521
Assignees
@wouterj
Labels
Config hasPR A Pull Request has already been submitted for this issue.
Milestone
5.1

Comments

@nicolas-grekas
Copy link
Member
Q A
Feature PR symfony/symfony#35871
PR author(s) @atailouloute
Merged in 5.1-dev
@xabbuh xabbuh added the Config label Apr 2, 2020
@xabbuh xabbuh added this to the 5.1 milestone Apr 2, 2020
@javiereguiluz
Copy link
Member

@atailouloute since the original code pull request doesn't have any description, I'm asking you if it's enough to document and do the changes that you added to the changelog:

 * The signature of method `NodeDefinition::setDeprecated()` has been updated to `NodeDefinition::setDeprecation(string $package, string $version, string $message)`.
 * The signature of method `BaseNode::setDeprecated()` has been updated to `BaseNode::setDeprecation(string $package, string $version, string $message)`.
 * Passing a null message to `BaseNode::setDeprecated()` to un-deprecate a node is deprecated

Thanks!

@wouterj wouterj self-assigned this Apr 11, 2020
@wouterj wouterj mentioned this issue Apr 11, 2020
Merged
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wouterj wouterj

Labels
Config hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
5.1
Development

Successfully merging a pull request may close this issue.

[OptionsResolver][Config][DI] Added package and version to deprecation features wouterj/symfony-docs
4 participants
@javiereguiluz @nicolas-grekas @wouterj @xabbuh
0