8000 [Notifier] Remove superfluous parameters in *Message::fromNotification() · Issue #13041 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Notifier] Remove superfluous parameters in *Message::fromNotification() #13041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue Feb 4, 2020 · 4 comments
Closed

[Notifier] Remove superfluous parameters in *Message::fromNotification() #13041

fabpot opened this issue Feb 4, 2020 · 4 comments
Labels
Keep open Notifier
Milestone
5.1

Comments

@fabpot
Copy link
Member
fabpot commented Feb 4, 2020
Q A
Feature PR symfony/symfony#35167
PR author(s) @fancyweb
Merged in 5.1-dev
@OskarStark OskarStark added this to the 5.1 milestone Feb 4, 2020
@OskarStark
Copy link
Contributor

Should be tackled after #13025

@carsonbot
Copy link
Collaborator

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

@JohJohan
Copy link
Contributor

#13025 is merged, i wanted to pick it up but only location i could find that mentions fromNotification() in the documentation is here https://symfony.com/doc/current/the-fast-track/en/25-notifier.html which we cannot edit? So someone with access should edit that and then we can close this issue.

@fancyweb
Copy link
Contributor

@OskarStark What do you think of closing this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Keep open Notifier
Projects
None yet
Milestone
5.1
Development

No branches or pull requests
5 participants
@fabpot @OskarStark @fancyweb @JohJohan @carsonbot
0