8000 [Messenger] Example missing parts? · Issue #12680 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] Example missing parts? #12680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WubbleWobble opened this issue Nov 23, 2019 · 9 comments
Closed

[Messenger] Example missing parts? #12680

WubbleWobble opened this issue Nov 23, 2019 · 9 comments
Labels
hasPR A Pull Request has already been submitted for this issue. Keep open Messenger

Comments

@WubbleWobble
Copy link
WubbleWobble commented Nov 23, 2019 •
edited
Loading

Hi,

I was looking at an example in the messenger documentation (Your own receiver):
https://symfony.com/doc/current/components/messenger.html#your-own-receiver

Messenger's concepts are new to me, and I know that code examples are sometimes partial, but there's too many bits missing for me to make sense of it.

Specifically $yourEnvelope, $this->connection and $this->findCustomStamp are never initialised, and $filePath is never used, all of which leaves me a bit confused when trying to figure out what's going on :)
@carsonbot
Copy link
Collaborator

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

@carsonbot
Copy link
Collaborator

Just a quick reminder to make a comment on this. If I don't hear anything I'll close this.

@carsonbot
Copy link
Collaborator

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!

@WubbleWobble
Copy link
Author
WubbleWobble commented Jan 15, 2021 •
edited
Loading

Needs to be re-opened - example code is still non-sensical.

Specifically missing (but called) $this->connection and $this->findCustomStamp()

@xabbuh xabbuh reopened this Jan 17, 2021
@wouterj wouterj removed the Stalled label Jan 17, 2021
@carsonbot
Copy link
Collaborator

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

@WubbleWobble
Copy link
Author

Example is still indeed gibberish - missing variables (e.g. $yourEnvelope) and missing methods as per previous comments.

We need an anti-Carsonbot bot.

@carsonbot carsonbot removed the Stalled label Jan 18, 2022
@carsonbot
Copy link
Collaborator

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

@WubbleWobble
Copy link
Author

Resolve thyself, Carson.

@carsonbot carsonbot removed the Stalled label Mar 4, 2023
@alexandre-daubois alexandre-daubois mentioned this issue Oct 19, 2023
Merged
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Oct 22, 2023
@WubbleWobble
Copy link
Author
WubbleWobble commented Oct 22, 2023 •
edited
Loading

The text passage above the code fragment in the documentation describes a scenario whereby we're needing to bridge the gap between a legacy system which provides orders as a CSV file, and an application where we're dispatching NewOrder messages.

Does this code match that scenario?

I don't have enough in-depth knowledge to know where there is a mismatch between the scenario and the code, or if indeed there is a way to achieve the scenario with the given code (e.g. if there's a CSV-reading Transport that could be used for the $connection that is instantiated in the constructor?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Keep open Messenger
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@javiereguiluz @wouterj @WubbleWobble @xabbuh @carsonbot
0