8000 Should we remove the GitHub repository reference in Components? · Issue #11295 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Should we remove the GitHub repository reference in Components? #11295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
8000
javiereguiluz opened this issue Apr 4, 2019 · 2 comments
Closed

Should we remove the GitHub repository reference in Components? #11295

javiereguiluz opened this issue Apr 4, 2019 · 2 comments
Labels
⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming hasPR A Pull Request has already been submitted for this issue.

Comments

@javiereguiluz
Copy link
Member
javiereguiluz commented Apr 4, 2019 •
edited by OskarStark
Loading

In this comment Fabien wonders if we could get rid of that phrase in all component docs:

components-repo-clone
@javiereguiluz javiereguiluz mentioned this issue Apr 4, 2019
Closed
@fabpot
Copy link
Member
fabpot commented Apr 4, 2019

I think/hope most of Symfony users are Composer users as well.

@dbrumann
Copy link
Contributor
dbrumann commented Apr 6, 2019

I will create a PR removing this phrase throughout the current documentation. #EUFOSSA

This was referenced Apr 6, 2019
Merged
Merged
wouterj added a commit that referenced this issue Apr 6, 2019
@wouterj
minor #11306 Remove GitHub references (dbrumann)
a87aaec 
This PR was squashed before being merged into the 3.4 branch (closes #11306).

Discussion
----------

 Remove GitHub references

Fixes #11295 for #EUFOSSA

I will open a second PR for 4.2 as there are some new components that need to be changed as well, namely:

* Mercure
* Messenger
* VarExporter
* WebLink

Commits
-------

5ee0c1b  Remove GitHub references
wouterj added a commit that referenced this issue Apr 6, 2019
@wouterj
minor #11307 Remove GitHub references (dbrumann)
c65a1d5 
This PR was merged into the 4.2 branch.

Discussion
----------

Remove GitHub references

Fixes #11295 for #EUFOSSA

See also #11306 aimed at 3.4 for the remaining references.

Commits
-------

928832a Removes github references.
@xabbuh xabbuh added ⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming hasPR A Pull Request has already been submitted for this issue. labels Apr 6, 2019
@dbrumann dbrumann mentioned this issue Apr 6, 2019
Merged
wouterj added a commit that referenced this issue Apr 6, 2019
@wouterj
minor #11308 Remove references to github repositories. (dbrumann)
5d19ec3 
This PR was merged into the master branch.

Discussion
----------

Remove references to github repositories.

Fixes #11295 for #EUFOSSA

See also PRs #11307 for 4.2 and #11306 for 3.4 for remaining references.

Commits
-------

33ecc96 Remove references to github repositories.
@wouterj wouterj added ⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming and removed ⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming labels Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fabpot @javiereguiluz @wouterj @xabbuh @dbrumann
0