You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
minor #8643 Updated reference articles to Symfony 4 (javiereguiluz)
This PR was squashed before being merged into the 4.0 branch (closes#8643
10000
).
Discussion
----------
Updated reference articles to Symfony 4
This fixes#8642.
-----
I want to update these two files more deeply in a separate PR, so here their changes are minimal:
* `reference/events.rst`
* `reference/dic_tags.rst`
-----
Now, some questions:
**1)** I've moved all custom Doctrine clases (custom DQL functions, custom DBAL types, custom database drivers, etc.) under `App\Bridge\Doctrine\` namespace (e.g. `Acme\HelloBundle\DQL\DatetimeFunction` -> `App\Bridge\Doctrine\DQL\DatetimeFunction`). I saw this in a Symfony app and I like it. Do you agree?
**2)** I don't know how to update this section from `/reference/configuration/framework.rst`:
```rst
resources
"""""""""
**type**: ``string[]`` **default**: ``['FrameworkBundle:Form']``
A list of all resources for form theming in PHP. This setting is not required
if you're using the Twig format for your templates, in that case refer to
:ref:`the form article <forms-theming-twig>`.
Assume you have custom global form themes in
``src/Resources/views/Form``, you can configure this like:
.. configuration-block::
.. code-block:: yaml
# config/packages/framework.yaml
framework:
templating:
form:
resources:
- 'WebsiteBundle:Form'
[...]
.. note::
The default form templates from ``FrameworkBundle:Form`` will always
be included in the form resources.
.. seealso::
See :ref:`forms-theming-global` for more information.
```
**3)** The `reference/configuration/doctrine.rst` contains A LOT of references to bundles, including options designed for bundles (`prefix`, `alias`, `is_bundle`) What should we do?
* Remove all references to bundles, including those options?
* Maintain all those options but update their explanations using the default Symfony Flex Recipe config? (see https://github.com/symfony/recipes/blob/db32040b48e9cf15299e7702a75a49e76999ff3f/doctrine/doctrine-bundle/1.6/config/packages/doctrine.yaml#L9-L15)
* ...?
Commits
-------
f709035 Restored the Assetic tags because they are removed in another PR
206bf70 Updated Doctrine config reference about bundles
e80995b Fixed PHP form theme resources
ef2a044 Remove App\Bridge\Doctrine\ namespace
da67105 Updated reference articles to Symfony 4
0 commit comments