minor #10154 [Command] No need to register the command manually (weaverryan)

javiereguiluz · javiereguiluz · commit f4c9872ef3c7 · 2018-10-08T10:28:14.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Command] No need to register the command manually Hey guys! Basically, when instantiating the `Application` from FrameworkBundle, you do not need to manually add the command manually. We also had a second, duplicated section that talked about testing with the kernel/container... but we do that already in the first code block. I think just got out of sync over years of updating & refactoring. I did test that we do NOT need to manually instantiate/add the command and we do NOT need to call `$kernel->boot()`. Commits ------- e0484d6 You do not need to re-add the command
diff --git a/console.rst b/console.rst
@@ -276,11 +276,9 @@ console::
     {
         public function testExecute()
         {
-            $kernel = self::bootKernel();
+            $kernel = static::createKernel();
             $application = new Application($kernel);
 
-            $application->add(new CreateUserCommand());
-
             $command = $application->find('app:create-user');
             $commandTester = new CommandTester($command);
             $commandTester->execute(array(
@@ -312,39 +310,6 @@ console::
     :class:`Symfony\\Component\\Console\\Application <Symfony\\Component\\Console\\Application>`
     and extend the normal ``\PHPUnit\Framework\TestCase``.
 
-To be able to use the fully set up service container for your console tests
-you can extend your test from
-:class:`Symfony\\Bundle\\FrameworkBundle\\Test\\KernelTestCase`::
-
-    // ...
-    use Symfony\Component\Console\Tester\CommandTester;
-    use Symfony\Bundle\FrameworkBundle\Console\Application;
-    use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
-
-    class CreateUserCommandTest extends KernelTestCase
-    {
-        public function testExecute()
-        {
-            $kernel = static::createKernel();
-            $kernel->boot();
-
-            $application = new Application($kernel);
-            $application->add(new CreateUserCommand());
-
-            $command = $application->find('app:create-user');
-            $commandTester = new CommandTester($command);
-            $commandTester->execute(array(
-                'command'  => $command->getName(),
-                'username' => 'Wouter',
-            ));
-
-            $output = $commandTester->getDisplay();
-            $this->assertContains('Username: Wouter', $output);
-
-            // ...
-        }
-    }
-
 Learn More
 ----------
 
