8000 added a check list for pull request submissions · symfony/symfony-docs@e92c57d · GitHub
[go: up one dir, main page]

Skip to content

Commit e92c57d

Browse files
committed
added a check list for pull request submissions
1 parent 0649201 commit e92c57d

File tree

1 file changed

+42
-0
lines changed

1 file changed

+42
-0
lines changed

contributing/code/patches.rst

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,48 @@ Submitting a Patch
44
Patches are the best way to provide a bug fix or to propose enhancements to
55
Symfony2.
66

7+
Check List
8+
----------
9+
10+
The purpose of the check list is to ensure that contributions may be reviewed
11+
with needless feedback loops to ensure that your contributions can be included
12+
into Symfony2 as quickly as possible.
13+
14+
.. warning::
15+
16+
All pull requests should include the following template in the request
17+
description:
18+
19+
.. code-block:: plain
20+
21+
Bug fix: [yes|no]
22+
Feature addition: [yes|no]
23+
Backwards compatibility break: [yes|no]
24+
Symfony2 tests pass: [yes|no]
25+
Fixes the following tickets: [comma separated list of tickets fixed by the PR]
26+
Description: [description of the change]
27+
28+
An example submission could now look as follows:
29+
30+
.. code-block:: plain
31+
32+
Bug fix: no
33+
Feature addition: yes
34+
Backwards compatibility break: no
35+
Symfony2 tests pass: yes
36+
Fixes the following tickets: -
37+
Description: Add X to Y to make the world a brighter place
38+
39+
Thank you for including the filled out template in your submission!
40+
41+
.. tip::
42+
43+
All feature addition's should be send to the "master" branch, while all
44+
bug fixes should be send to the oldest still active branch. Furthermore
45+
submissions should never break backwards compatibility. Please
46+
mark any submissions as "[WIP]" in the title in case the submission
47+
is not yet complete (for example if the tests do not yet pass).
48+
749
Initial Setup
850
-------------
951

0 commit comments

Comments
 (0)
0