feature #12384 Documented the new REMOTE_ADDR option (javiereguiluz)

wouterj · wouterj · commit dd8ff156631d · 2019-11-09T12:29:38.000+01:00
This PR was squashed before being merged into the 4.4 branch (closes #12384). Discussion ---------- Documented the new REMOTE_ADDR option Fixes #12382. @mcfedr @stof @nicolas-grekas please review this carefully and tell me if we should add or remove anything else from this article. Thanks! Commits ------- c8e9ff5 Documented the new REMOTE_ADDR option
diff --git a/deployment/proxies.rst b/deployment/proxies.rst
@@ -65,13 +65,18 @@ In this case, you'll need to - *very carefully* - trust *all* proxies.
 
        // ...
        Request::setTrustedProxies(
-           // trust *all* requests
-           ['127.0.0.1', $request->server->get('REMOTE_ADDR')],
+           // trust *all* requests (the 'REMOTE_ADDR' string is replaced at
+           // run time by $_SERVER['REMOTE_ADDR'])
+           ['127.0.0.1', 'REMOTE_ADDR'],
 
            // if you're using ELB, otherwise use a constant from above
            Request::HEADER_X_FORWARDED_AWS_ELB
        );
 
+.. versionadded:: 4.4
+
+    The support for the ``REMOTE_ADDR`` option was introduced in Symfony 4.4.
+
 That's it! It's critical that you prevent traffic from all non-trusted sources.
 If you allow outside traffic, they could "spoof" their true IP address and
 other information.
