minor #9079 preUpdate Event Listener On Uploaded Imagery (matt9mg)

xabbuh · xabbuh · commit dc6ba1ac7d1b · 2018-08-07T11:15:16.000+02:00
This PR was submitted for the 4.0 branch but it was squashed and merged into the 2.8 branch instead (closes #9079). Discussion ---------- preUpdate Event Listener On Uploaded Imagery I've noticed a scenario (a bit of an edge case when uploading imagery). If you have an entity (say a brochure) but you can give it a title and an image and the image title can be updated without the image being updated (the file type is not an UploadedFile but a File on save it'll persist the full file path instead of the desired filename. The above is a safety measure to ensure the above. Commits ------- a4cc43a preUpdate Event Listener On Uploaded Imagery
diff --git a/controller/upload_file.rst b/controller/upload_file.rst
@@ -310,6 +310,7 @@ automatically upload the file when persisting the entity::
     namespace AppBundle\EventListener;
 
     use Symfony\Component\HttpFoundation\File\UploadedFile;
+    use Symfony\Component\HttpFoundation\File\File;
     use Doctrine\ORM\Event\LifecycleEventArgs;
     use Doctrine\ORM\Event\PreUpdateEventArgs;
     use AppBundle\Entity\Product;
@@ -351,6 +352,10 @@ automatically upload the file when persisting the entity::
             if ($file instanceof UploadedFile) {
                 $fileName = $this->uploader->upload($file);
                 $entity->setBrochure($fileName);
+            } elseif ($file instanceof File) {
+                // prevents the full file path being saved on updates
+                // as the path is set on the postLoad listener
+                $entity->setBrochure($file->getFilename());
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -310,6 +310,7 @@ automatically upload the file when persisting the entity::`
`310`	`310`	`namespace AppBundle\EventListener;`
`311`	`311`
`312`	`312`	`use Symfony\Component\HttpFoundation\File\UploadedFile;`
	`313`	`+ use Symfony\Component\HttpFoundation\File\File;`
`313`	`314`	`use Doctrine\ORM\Event\LifecycleEventArgs;`
`314`	`315`	`use Doctrine\ORM\Event\PreUpdateEventArgs;`
`315`	`316`	`use AppBundle\Entity\Product;`
`@@ -351,6 +352,10 @@ automatically upload the file when persisting the entity::`
`351`	`352`	`if ($file instanceof UploadedFile) {`
`352`	`353`	`$fileName = $this->uploader->upload($file);`
`353`	`354`	`$entity->setBrochure($fileName);`
	`355`	`+ } elseif ($file instanceof File) {`
	`356`	`+ // prevents the full file path being saved on updates`
	`357`	`+ // as the path is set on the postLoad listener`
	`358`	`+ $entity->setBrochure($file->getFilename());`
`354`	`359`	`}`
`355`	`360`	`}`
`356`	`361`	`}`