8000 minor #12606 BC promise: only optional arguments can be removed (teoh… · symfony/symfony-docs@d9bd18f · GitHub
[go: up one dir, main page]

Skip to content

Commit d9bd18f

Browse files
committed
minor #12606 BC promise: only optional arguments can be removed (teohhanhui)
This PR was merged into the 3.4 branch. Discussion ---------- BC promise: only optional arguments can be removed Fixes symfony/symfony#34230 (comment) I've changed `Yes` to `No`, since it makes more sense, i.e. it's not allowed, unless... Additional question: Should I also change `No` to `No [3]_` for traits? Or is there a specific reason why it's absolutely not allowed on traits? Commits ------- ef477e3 BC promise: only optional arguments can be removed
2 parents 6c67c6e + ef477e3 commit d9bd18f

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

contributing/code/bc.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ Change name No
204204
Move to parent interface Yes
205205
Add argument without a default value No
206206
Add argument with a default value No
207-
Remove argument Yes [3]_
207+
Remove argument No [3]_
208208
Add default value to an argument No
209209
Remove default value of an argument No
210210
Add type hint to an argument No
@@ -272,7 +272,7 @@ Make final No [6]_
272272
Move to parent class Yes
273273
Add argument without a default value No
274274
Add argument with a default value No [7]_ [8]_
275-
Remove argument Yes [3]_
275+
Remove argument No [3]_
276276
Add default value to an argument No [7]_ [8]_
277277
Remove default value of an argument No
278278
Add type hint to an argument No [7]_ [8]_
@@ -291,7 +291,7 @@ Make public No [7]_ [8]_
291291
Move to parent class Yes
292292
Add argument without a default value No [7]_
293293
Add argument with a default value No [7]_ [8]_
294-
Remove argument Yes [3]_
294+
Remove argument No [3]_
295295
Add default value to an argument No [7]_ [8]_
296296
Remove default value of an argument No [7]_
297297
Add type hint to an argument No [7]_ [8]_
@@ -416,8 +416,8 @@ Turn static into non static No
416416
.. [2] The added parent interface must not introduce any new methods that don't
417417
exist in the interface already.
418418
419-
.. [3] Only the last argument(s) of a method may be removed, as PHP does not
420-
care about additional arguments that you pass to a method.
419+
.. [3] Only the last optional argument(s) of a method may be removed, as PHP
420+
does not care about additional arguments that you pass to a method.
421421
422422
.. [4] When changing the parent class, the original parent class must remain an
423423
ancestor of the class.

0 commit comments

Comments
 (0)
0