bug #3771 Fix function example in expression language component (raulfraile)

weaverryan · weaverryan · commit b32f9f2981ae · 2014-07-11T17:09:25.000-05:00
This PR was submitted for the master branch but it was merged into the 2.4 branch instead (closes #3771). Discussion ---------- Fix function example in expression language component The is_string check needs to be part of the runtime code, not of the compilation code, because it needs to check that the argument is a string, not the compiled code to access it (which is always a string as it is source code. cc @stof Commits ------- db710c4 Removed return statement bc673f3 Fix function example in expression language component
diff --git a/components/expression_language/extending.rst b/components/expression_language/extending.rst
@@ -35,11 +35,7 @@ This method has 3 arguments:
 
     $language = new ExpressionLanguage();
     $language->register('lowercase', function ($str) {
-        if (!is_string($str)) {
-            return $str;
-        }
-
-        return sprintf('strtolower(%s)', $str);
+        is_string(%1$s) ? strtolower(%1$s) : %1$s;
     }, function ($arguments, $str) {
         if (!is_string($str)) {
             return $str;
