Merge branch '2.8' into 3.4

javiereguiluz · javiereguiluz · commit abc600787c1f · 2018-03-13T15:39:54.000+01:00
* 2.8: [#9413] some minor tweaks Ask users to create two commits for reproducers
diff --git a/contributing/code/reproducer.rst b/contributing/code/reproducer.rst
@@ -42,9 +42,10 @@ edition. To do so:
    ``git clone git://github.com/YOUR-GITHUB-USERNAME/symfony-standard.git``
 #. Browse the project and create a new branch (e.g. ``issue_23567``,
    ``reproduce_23657``, etc.)
+#. Add and commit the changes generated by Symfony.
 #. Now you must add the minimum amount of code to reproduce the bug. This is the
    trickiest part and it's explained a bit more later.
-#. Add, commit and push all your changes.
+#. Add, commit and push all your own changes.
 #. Add a comment in your original issue report to share the URL of your forked
    project (e.g. ``https://github.com/YOUR-GITHUB-USERNAME/symfony-standard/tree/issue_23567``)
    and, if necessary, explain the steps to reproduce (e.g. "browse this URL",
diff --git a/form/unit_testing.rst b/form/unit_testing.rst
@@ -57,8 +57,9 @@ The simplest ``TypeTestCase`` implementation looks like the following::
             // submit the data to the form directly
             $form->submit($formData);
 
-            $objectToCompare = $form->getData();
             $this->assertTrue($form->isSynchronized());
+
+            // check that $objectToCompare was modified as expected when the form was submitted
             $this->assertEquals($object, $objectToCompare);
 
             $view = $form->createView();
