minor #9903 Transition from mt_rand to random_int (sbol-coolblue)

javiereguiluz · javiereguiluz · commit 998659e8b7c1 · 2018-06-09T11:39:10.000+02:00
This PR was submitted for the master branch but it was squashed and merged into the 2.8 branch instead (closes #9903). Discussion ---------- Transition from mt_rand to random_int Considering that mt_rand has a warning notice surrounding it, having the examples use random_int nudges people in the direction of the more secure way of generating random ints, building better habits. Commits ------- 2e68ee7 Transition from mt_rand to random_int
diff --git a/controller.rst b/controller.rst
@@ -68,7 +68,7 @@ class::
          */
         public function numberAction($max)
         {
-            $number = mt_rand(0, $max);
+            $number = random_int(0, $max);
 
             return new Response(
                 '<html><body>Lucky number: '.$number.'</body></html>'
diff --git a/page_creation.rst b/page_creation.rst
@@ -53,7 +53,7 @@ random) number and prints it. To do that, create a "Controller class" and a
          */
         public function numberAction()
         {
-            $number = mt_rand(0, 100);
+            $number = random_int(0, 100);
 
             return new Response(
                 '<html><body>Lucky number: '.$number.'</body></html>'
@@ -123,7 +123,7 @@ variable so we can render that::
          */
         public function numberAction()
         {
-            $number = mt_rand(0, 100);
+            $number = random_int(0, 100);
 
             return $this->render('lucky/number.html.twig', array(
                 'number' => $number,

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ class::`
`68`	`68`	`*/`
`69`	`69`	`public function numberAction($max)`
`70`	`70`	`{`
`71`		`- $number = mt_rand(0, $max);`
	`71`	`+ $number = random_int(0, $max);`
`72`	`72`
`73`	`73`	`return new Response(`
`74`	`74`	`'<html><body>Lucky number: '.$number.'</body></html>'`