minor #13363 Move login route to const (JakubSzczesniak)

javiereguiluz · javiereguiluz · commit 8eb21f4727c5 · 2020-03-17T15:14:33.000+01:00
This PR was submitted for the 5.0 branch but it was merged into the 4.4 branch instead (closes #13363). Discussion ---------- Move login route to const This is more stable solution. I spent half of hour to fix bug, because I forgot change route name in 2 places. Commits ------- 5b0a583 Update form_login_setup.rst
diff --git a/security/form_login_setup.rst b/security/form_login_setup.rst
@@ -191,6 +191,8 @@ a traditional HTML form that submits to ``/login``:
     class LoginFormAuthenticator extends AbstractFormLoginAuthenticator implements PasswordAuthenticatedInterface
     {
         use TargetPathTrait;
+        
+        public const LOGIN_ROUTE = 'app_login';
 
         private $entityManager;
         private $urlGenerator;
@@ -207,7 +209,7 @@ a traditional HTML form that submits to ``/login``:
 
         public function supports(Request $request)
         {
-            return 'app_login' === $request->attributes->get('_route')
+            return self::LOGIN_ROUTE === $request->attributes->get('_route')
                 && $request->isMethod('POST');
         }
 
@@ -260,7 +262,7 @@ a traditional HTML form that submits to ``/login``:
 
         protected function getLoginUrl()
         {
-            return $this->urlGenerator->generate('app_login');
+            return $this->urlGenerator->generate(self::LOGIN_ROUTE);
         }
     }
 

Original file line number	Diff line number	Diff line change
@@ -191,6 +191,8 @@ a traditional HTML form that submits to ``/login``:
`191`	`191`	`class LoginFormAuthenticator extends AbstractFormLoginAuthenticator implements PasswordAuthenticatedInterface`
`192`	`192`	`{`
`193`	`193`	`use TargetPathTrait;`
	`194`	`+`
	`195`	`+ public const LOGIN_ROUTE = 'app_login';`
`194`	`196`
`195`	`197`	`private $entityManager;`
`196`	`198`	`private $urlGenerator;`
@@ -207,7 +209,7 @@ a traditional HTML form that submits to ``/login``:
`207`	`209`
`208`	`210`	`public function supports(Request $request)`
`209`	`211`	`{`
`210`		`- return 'app_login' === $request->attributes->get('_route')`
	`212`	`+ return self::LOGIN_ROUTE === $request->attributes->get('_route')`
`211`	`213`	`&& $request->isMethod('POST');`
`212`	`214`	`}`
`213`	`215`
@@ -260,7 +262,7 @@ a traditional HTML form that submits to ``/login``:
`260`	`262`
`261`	`263`	`protected function getLoginUrl()`
`262`	`264`	`{`
`263`		`- return $this->urlGenerator->generate('app_login');`
	`265`	`+ return $this->urlGenerator->generate(self::LOGIN_ROUTE);`
`264`	`266`	`}`
`265`	`267`	`}`
`266`	`268`