minor #4808 Email message instantiation changed to a more 'symfonysh' way. (alebo)

wouterj · wouterj · commit 892586bf3ceb · 2015-01-16T17:16:32.000+01:00
This PR was merged into the 2.3 branch. Discussion ---------- Email message instantiation changed to a more 'symfonysh' way. | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | I believe that using a static factory method for instantiation isn't the best way to do it in Symfony. So I suggest updating the Sending Emails example. Commits ------- 7f8b051 Changed email message instantiation to a more 'symfonysh' way.
diff --git a/cookbook/email/email.rst b/cookbook/email/email.rst
@@ -103,7 +103,8 @@ an email is pretty straightforward::
 
     public function indexAction($name)
     {
-        $message = \Swift_Message::newInstance()
+        $mailer = $this->get('mailer');
+        $message = $mailer->createMessage()
             ->setSubject('Hello Email')
             ->setFrom('send@example.com')
             ->setTo('recipient@example.com')
@@ -114,7 +115,7 @@ an email is pretty straightforward::
                 )
             )
         ;
-        $this->get('mailer')->send($message);
+        $mailer->send($message);
 
         return $this->render(...);
     }

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,8 @@ an email is pretty straightforward::`
`103`	`103`
`104`	`104`	`public function indexAction($name)`
`105`	`105`	`{`
`106`		`- $message = \Swift_Message::newInstance()`
	`106`	`+ $mailer = $this->get('mailer');`
	`107`	`+ $message = $mailer->createMessage()`
`107`	`108`	`->setSubject('Hello Email')`
`108`	`109`	`->setFrom('send@example.com')`
`109`	`110`	`->setTo('recipient@example.com')`
`@@ -114,7 +115,7 @@ an email is pretty straightforward::`
`114`	`115`	`)`
`115`	`116`	`)`
`116`	`117`	`;`
`117`		`- $this->get('mailer')->send($message);`
	`118`	`+ $mailer->send($message);`
`118`	`119`
`119`	`120`	`return $this->render(...);`
`120`	`121`	`}`