minor #11149 do not mock the validator in form type tests (xabbuh)

javiereguiluz · javiereguiluz · commit 66716ae832e3 · 2019-03-14T11:05:43.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- do not mock the validator in form type tests Commits ------- 272e479 do not mock the validator in form type tests
diff --git a/form/unit_testing.rst b/form/unit_testing.rst
@@ -182,31 +182,22 @@ allows you to return a list of extensions to register::
     namespace Tests\AppBundle\Form\Type;
 
     // ...
-    use AppBundle\Form\Type\TestedType;
     use Symfony\Component\Form\Extension\Validator\ValidatorExtension;
-    use Symfony\Component\Form\Form;
-    use Symfony\Component\Validator\ConstraintViolationList;
-    use Symfony\Component\Validator\Mapping\ClassMetadata;
-    use Symfony\Component\Validator\Validator\ValidatorInterface;
+    use Symfony\Component\Validator\Validation;
 
     class TestedTypeTest extends TypeTestCase
     {
-        private $validator;
-
         protected function getExtensions()
         {
-            $this->validator = $this->createMock(ValidatorInterface::class);
-            // use getMock() on PHPUnit 5.3 or below
-            // $this->validator = $this->getMock(ValidatorInterface::class);
-            $this->validator
-                ->method('validate')
-                ->will($this->returnValue(new ConstraintViolationList()));
-            $this->validator
-                ->method('getMetadataFor')
-                ->will($this->returnValue(new ClassMetadata(Form::class)));
+            $validator = Validation::createValidator();
+
+            // or if you also need to read constraints from annotations
+            $validator = Validation::createValidatorBuilder()
+                ->enableAnnotationMapping()
+                ->getValidator();
 
             return [
-                new ValidatorExtension($this->validator),
+                new ValidatorExtension($validator),
             ];
         }
 
