Merge branch '4.3' into 4.4

javiereguiluz · javiereguiluz · commit 50aac703bf9c · 2019-10-03T11:10:55.000+02:00
* 4.3:
  Update unit_testing.rst
  Update events.rst
diff --git a/create_framework/unit_testing.rst b/create_framework/unit_testing.rst
@@ -49,7 +49,8 @@ resolver. Modify the framework to make use of them::
     namespace Simplex;
 
     // ...
-
+    
+    use Calendar\Controller\LeapYearController;
     use Symfony\Component\HttpKernel\Controller\ArgumentResolverInterface;
     use Symfony\Component\HttpKernel\Controller\ControllerResolverInterface;
     use Symfony\Component\Routing\Matcher\UrlMatcherInterface;
@@ -125,7 +126,7 @@ Execute this test by running ``phpunit`` in the ``example.com`` directory:
 
 .. code-block:: terminal
 
-    $ phpunit
+    $ ./vendor/bin/phpunit
 
 .. note::
 
@@ -164,11 +165,9 @@ Response::
             ->expects($this->once())
             ->method('match')
             ->will($this->returnValue([
-                '_route' => 'foo',
-                'name' => 'Fabien',
-                '_controller' => function ($name) {
-                    return new Response('Hello '.$name);
-                }
+                '_route' => 'is_leap_year/{year}',
+                'year' => '2000',
+                '_controller' => [new LeapYearController(), 'index']
             ]))
         ;
         $matcher
@@ -196,7 +195,7 @@ coverage feature (you need to enable `XDebug`_ first):
 
 .. code-block:: terminal
 
-    $ phpunit --coverage-html=cov/
+    $ ./vendor/bin/phpunit --coverage-html=cov/
 
 Open ``example.com/cov/src/Simplex/Framework.php.html`` in a browser and check
 that all the lines for the Framework class are green (it means that they have
@@ -206,7 +205,7 @@ Alternatively you can output the result directly to the console:
 
 .. code-block:: terminal
 
-    $ phpunit --coverage-text
+    $ ./vendor/bin/phpunit --coverage-text
 
 Thanks to the clean object-oriented code that we have written so far, we have
 been able to write unit-tests to cover all possible use cases of our
diff --git a/reference/events.rst b/reference/events.rst
@@ -87,6 +87,8 @@ Typically, this is used to map URL routing parameters to their corresponding
 named arguments; or pass the current request when the ``Request`` type-hint is
 found::
 
+    use Symfony\Component\HttpKernel\Event\ControllerArgumentsEvent;
+
     public function onKernelControllerArguments(ControllerArgumentsEvent $event)
     {
         // ...
@@ -149,6 +151,8 @@ This event is dispatched after the controller or any ``kernel.view`` listener
 returns a ``Response`` object. It's useful to modify or replace the response
 before sending it back (e.g. add/modify HTTP headers, add cookies, etc.)::
 
+    use Symfony\Component\HttpKernel\Event\ResponseEvent;
+
     public function onKernelResponse(ResponseEvent $event)
     {
         $response = $event->getResponse();
@@ -176,6 +180,8 @@ This event is dispatched after the ``kernel.response`` event. It's useful to res
 the global state of the application (for example, the translator listener resets
 the translator's locale to the one of the parent request)::
 
+    use Symfony\Component\HttpKernel\Event\FinishRequestEvent;
+
     public function onKernelFinishRequest(FinishRequestEvent $event)
     {
         if (null === $parentRequest = $this->requestStack->getParentRequest()) {
