Merge branch '4.3' into 4.4

javiereguiluz · javiereguiluz · commit 46fef055311a · 2019-07-04T13:27:11.000+02:00
* 4.3:
  [Messenger] ReceiverInterface updated
diff --git a/components/messenger.rst b/components/messenger.rst
@@ -282,23 +282,38 @@ do is to write your own CSV receiver::
             $this->filePath = $filePath;
         }
 
-        public function receive(callable $handler): void
+        public function get(): void
         {
             $ordersFromCsv = $this->serializer->deserialize(file_get_contents($this->filePath), 'csv');
 
             foreach ($ordersFromCsv as $orderFromCsv) {
                 $order = new NewOrder($orderFromCsv['id'], $orderFromCsv['account_id'], $orderFromCsv['amount']);
 
-                $handler(new Envelope($order));
+                $envelope = new Envelope($order);
+
+                $handler($envelope);
             }
+
+            return [$envelope];
         }
 
-        public function stop(): void
+        public function ack(Envelope $envelope): void
         {
-            // noop
+            // Add information about the handled message
+        }
+
+        public function reject(Envelope $envelope): void
+        {
+            // Reject the message if needed
         }
     }
 
+.. versionadded:: 4.3
+
+    In Symfony 4.3, the ``ReceiverInterface`` has changed its methods as shown
+    in the example above. You may need to update your code if you used this
+    interface in previous Symfony versions.
+
 Receiver and Sender on the same Bus
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 

Original file line number	Diff line number	Diff line change
`@@ -282,23 +282,38 @@ do is to write your own CSV receiver::`
`282`	`282`	`$this->filePath = $filePath;`
`283`	`283`	`}`
`284`	`284`
`285`		`- public function receive(callable $handler): void`
	`285`	`+ public function get(): void`
`286`	`286`	`{`
`287`	`287`	`$ordersFromCsv = $this->serializer->deserialize(file_get_contents($this->filePath), 'csv');`
`288`	`288`
`289`	`289`	`foreach ($ordersFromCsv as $orderFromCsv) {`
`290`	`290`	`$order = new NewOrder($orderFromCsv['id'], $orderFromCsv['account_id'], $orderFromCsv['amount']);`
`291`	`291`
`292`		`- $handler(new Envelope($order));`
	`292`	`+ $envelope = new Envelope($order);`
	`293`	`+`
	`294`	`+ $handler($envelope);`
`293`	`295`	`}`
	`296`	`+`
	`297`	`+ return [$envelope];`
`294`	`298`	`}`
`295`	`299`
`296`		`- public function stop(): void`
	`300`	`+ public function ack(Envelope $envelope): void`
`297`	`301`	`{`
`298`		`- // noop`
	`302`	`+ // Add information about the handled message`
	`303`	`+ }`
	`304`	`+`
	`305`	`+ public function reject(Envelope $envelope): void`
	`306`	`+ {`
	`307`	`+ // Reject the message if needed`
`299`	`308`	`}`
`300`	`309`	`}`
`301`	`310`
	`311`	`+.. versionadded:: 4.3`
	`312`	`+`
	`313`	+ In Symfony 4.3, the ``ReceiverInterface`` has changed its methods as shown
	`314`	`+ in the example above. You may need to update your code if you used this`
	`315`	`+ interface in previous Symfony versions.`
	`316`	`+`
`302`	`317`	`Receiver and Sender on the same Bus`
`303`	`318`	`~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~`
`304`	`319`