minor #10213 [Security] Fix wrong usage in custom authenticator checking if password is invalid (norkunas)

xabbuh · xabbuh · commit 224afc0f8d4e · 2018-08-24T17:36:14.000+02:00
This PR was merged into the 2.8 branch. Discussion ---------- [Security] Fix wrong usage in custom authenticator checking if password is invalid ```Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface::isPasswordValid``` expects an UserInterface and a password, but example arguments was provided like for `Symfony\Component\Security\Core\Encoder\PasswordEncoderInterface`  Commits ------- 94f2951 Fix wrong usage in custom authenticator checking if password is invalid
diff --git a/security/custom_password_authenticator.rst b/security/custom_password_authenticator.rst
@@ -69,7 +69,7 @@ the user::
                 if ('' === ($givenPassword = $token->getCredentials())) {
                     throw new BadCredentialsException('The given password cannot be empty.');
                 }
-                if (!$this->encoder->isPasswordValid($user->getPassword(), $givenPassword, $user->getSalt())) {
+                if (!$this->encoder->isPasswordValid($user, $givenPassword)) {
                     throw new BadCredentialsException('The given password is invalid.');
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ the user::`
`69`	`69`	`if ('' === ($givenPassword = $token->getCredentials())) {`
`70`	`70`	`throw new BadCredentialsException('The given password cannot be empty.');`
`71`	`71`	`}`
`72`		`- if (!$this->encoder->isPasswordValid($user->getPassword(), $givenPassword, $user->getSalt())) {`
	`72`	`+ if (!$this->encoder->isPasswordValid($user, $givenPassword)) {`
`73`	`73`	`throw new BadCredentialsException('The given password is invalid.');`
`74`	`74`	`}`
`75`	`75`	`}`