minor #13511 [Testing] Change deprecated assertContains to assertStringContainsString (Wojciech Kania)

javiereguiluz · javiereguiluz · commit 0147fe64e7d8 · 2020-04-09T08:38:05.000+02:00
This PR was merged into the 5.0 branch. Discussion ---------- [Testing] Change deprecated assertContains to assertStringContainsString Symfony 5 requires PHP 7.2. PHPUnit Bridge for this version by default use [PHPUnit 8.3](https://symfony.com/doc/current/components/phpunit_bridge.html#modified-phpunit-script). The assertContains is [deprecated](sebastianbergmann/phpunit#3425) and in PHPUnit 9 throws an error. Commits ------- e4d8c27 [Testing] Change deprecated assertContains to assertStringContainsString
diff --git a/console.rst b/console.rst
@@ -356,7 +356,7 @@ console::
 
             // the output of the command in the console
             $output = $commandTester->getDisplay();
-            $this->assertContains('Username: Wouter', $output);
+            $this->assertStringContainsString('Username: Wouter', $output);
 
             // ...
         }
diff --git a/create_framework/unit_testing.rst b/create_framework/unit_testing.rst
@@ -49,7 +49,7 @@ resolver. Modify the framework to make use of them::
     namespace Simplex;
 
     // ...
-    
+
     use Calendar\Controller\LeapYearController;
     use Symfony\Component\HttpKernel\Controller\ArgumentResolverInterface;
     use Symfony\Component\HttpKernel\Controller\ControllerResolverInterface;
@@ -183,7 +183,7 @@ Response::
         $response = $framework->handle(new Request());
 
         $this->assertEquals(200, $response->getStatusCode());
-        $this->assertContains('Yep, this is a leap year!', $response->getContent());
+        $this->assertStringContainsString('Yep, this is a leap year!', $response->getContent());
     }
 
 In this test, we simulate a route that matches and returns a simple
diff --git a/testing.rst b/testing.rst
@@ -270,7 +270,7 @@ Or test against the response content directly if you just want to assert that
 the content contains some text or in case that the response is not an XML/HTML
 document::
 
-    $this->assertContains(
+    $this->assertStringContainsString(
         'Hello World',
         $client->getResponse()->getContent()
     );
@@ -316,7 +316,7 @@ document::
         );
 
         // asserts that the response content contains a string
-        $this->assertContains('foo', $client->getResponse()->getContent());
+        $this->assertStringContainsString('foo', $client->getResponse()->getContent());
         // ...or matches a regex
         $this->assertRegExp('/foo(bar)?/', $client->getResponse()->getContent());
 

Original file line number	Diff line number	Diff line change
`@@ -356,7 +356,7 @@ console::`
`356`	`356`
`357`	`357`	`// the output of the command in the console`
`358`	`358`	`$output = $commandTester->getDisplay();`
`359`		`- $this->assertContains('Username: Wouter', $output);`
	`359`	`+ $this->assertStringContainsString('Username: Wouter', $output);`
`360`	`360`
`361`	`361`	`// ...`
`362`	`362`	`}`