Profiler activation #7859
Merged
Profiler activation #7859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,6 +39,10 @@ class WebProfilerExtension extends Extension | |||
| */ | |||
| public function load(array $configs, ContainerBuilder $container) | |||
| { | |||
| if (!$container->hasParameter('profiler.class')) { | |||
There was a problem hiding this comment.
This would break if FrameworkBundle is registered after WebProfilerBundle.
There was a problem hiding this comment.
Indeed. I have not changed this part of the old PR.
Before: enabled: true # the profiler is enabled and data are collected enabled: false # the profiler is enabled but data are not collected (data can be collected on demand) No way to disable the profiler After: enabled: true # the profiler is enabled and data are collected collect: true enabled: true # the profiler is enabled but data are not collected (data can be collected on demand) collect: false enabled: false # the profiler is disabled
fabpot
added a commit
that referenced
this pull request
Apr 26, 2013
This PR was merged into the master branch. Discussion ---------- Profiler activation | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7064, #7071 | License | MIT | Doc PR | symfony/symfony-docs#2565 As stated in #7071, there is no way to disable the profiler completely. Even when the `enabled` flag is set to `false`, the profiler is still registered but the data collectors are not activated. Now, when `enabled` is `false`, the profiler is disabled. To get the old `false` behavior, you now need to set `enabled` to `true` and set the new `collect` flag to `false`. Todo: - [x] update docs - [x] update Symfony SE -- not needed Commits ------- 88ebd62 fixed 8000 the registration of the web profiler when the profiler is disabled a11f901 [FrameworkBundle] added a way to disable the profiler f675dd8 Truly disabled profiler in prod
|
What is the use-case for an enabled profiler that does not collect any data? |
|
@Tobion enabling it only for some uri (with a request matcher) or enablign it only for some tests of the testsuite instead of all of them (to make the functional testsuite faster) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Apply
2E92
ing suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in #7071, there is no way to disable the profiler completely. Even when the
enabledflag is set tofalse, the profiler is still registered but the data collectors are not activated.Now, when
enabledisfalse, the profiler is disabled. To get the oldfalsebehavior, you now need to setenabledtotrueand set the newcollectflag tofalse.Todo: