[Validator] let the SlugValidator accept AsciiSlugger results
#60426
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 7.3 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix #58542 (comment) |
| License | MIT |
SlugValidator accept AsciiSlugger results
alexandre-daubois
approved these changes
May 16, 2025
| /** | ||
| * @testWith ["PHP"] | ||
| * @testWith ["Symfony is cool"] | ||
| * @testWith ["Lorem ipsum dolor sit amet"] |
There was a problem hiding this comment.
Nitpick, you may use only one testWith instead of three, like the other usage above?
There was a problem hiding this comment.
In fact, it's even required not to repeat the annotation.
There was a problem hiding this comment.
Before:
$ php ./phpunit src/Symfony/Component/Validator/Tests/Constraints/SlugValidatorTest.php
PHPUnit 9.6.23 by Sebastian Bergmann and contributors.
Testing Symfony\Component\Validator\Tests\Constraints\SlugValidatorTest
.............. 14 / 14 (100%)
Time: 00:00.059, Memory: 39.02 MB
OK (14 tests, 19 assertions)
Now:
$ php ./phpunit src/Symfony/Component/Validator/Tests/Constraints/SlugValidatorTest.php
PHPUnit 9.6.23 by Sebastian Bergmann and contributors.
Testing Symfony\Component\Validator\Tests\Constraints\SlugValidatorTest
................. 17 / 17 (100%)
Time: 00:00.047, Memory: 43.86 MB
OK (17 tests, 22 assertions)
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.