[Validator] fix test setup and skip test until bug is fixed in PHP #59895
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 7.3 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
xabbuh
commented
Mar 2, 2025
| use Symfony\Component\Validator\Constraints\NotBlank; | ||
| use Symfony\Component\Validator\Constraints\NotNull; | ||
| use Symfony\Component\Validator\Constraints\When; | ||
|
|
||
| #[When(expression: static function () { | ||
| return true; | ||
| }, constraints: new NotNull() |
There was a problem hiding this comment.
Symfony\Component\Validator\Exception\ConstraintDefinitionException: The constraint "Symfony\Component\Validator\Constraints\NotNull" cannot be put on classes.
xabbuh
commented
Mar 2, 2025
| @@ -118,6 +118,8 @@ public function testAttributes() | |||
| */ | |||
| public function testAttributesWithClosure() | |||
| { | |||
| $this->markTestSkipped('Requires https://github.com/php/php-src/issues/17851 to be fixed'); | |||
There was a problem hiding this comment.
@alexandre-daubois and me are keeping an eye on php/php-src#17851 to revert this change once the bug in PHP has been fixed
alexandre-daubois
approved these changes
Mar 2, 2025
nicolas-grekas
approved these changes
Mar 2, 2025
mtarld
approved these changes
Mar 2, 2025
fabpot
approved these changes
Mar 3, 2025
|
Thank you @xabbuh. |
|
FYI: Should be fixed in the latest PHP master now 🤞 |
|
Thank you @TimWolla! I'll take care of updating our code accordingly |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 30, 2025
…n `php-src` (alexandre-daubois) This PR was merged into the 7.3 branch. Discussion ---------- [Validator] Don't skip `WhenTest` case after fix merge in `php-src` | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Revert skip being introduced in #59895 after the fix of php/php-src#17851. Commits ------- 8f4bb30 [Validator] Don't skip `WhenTest` case after fix merge in `php-src`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.