[Messenger] Add keepalive support to Doctrine transport #59601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jan 23, 2025
8000
OskarStark
reviewed
Jan 23, 2025
silasjoisten
commented
Jan 23, 2025
src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php
Show resolved
Hide resolved
fb7453b to
1192312
Compare
OskarStark
approved these changes
Jan 24, 2025
HypeMC
approved these changes
Jan 24, 2025
silasjoisten
commented
Jan 24, 2025
fabpot
approved these changes
Jan 25, 2025
ad5460f to
970c07b
Compare
|
Thank you @silasjoisten. |
|
Congrats on your first contribution to the Symfony Core @silasjoisten 🎉 |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Mar 10, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [Messenger] Keepalive support for Doctrine & Redis Contains #20736 which should be merged first. Keepalive support for the Doctrine and Redis transports was added in symfony/symfony#59601 and symfony/symfony#59360, respectively. Commits ------- abdd3c9 [Messenger] Keepalive support for Doctrine & Redis
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request adds keepalive support to the Doctrine Messenger transport by implementing the keepalive method in the Connection class. This enhancement aligns Doctrine transport with the existing keepalive functionality already supported by other Messenger transports, such as Redis and Beanstalkd.
The keepalive principle was introduced in Symfony 7.2 to address issues where long-running message processing could lead to premature message timeouts and redelivery. By keeping the message “alive” on the transport layer, the message remains marked as being processed until explicitly acknowledged.
Other transports like Redis and Beanstalkd have already implemented this feature. This PR extends the functionality to the Doctrine transport.