[TwigBridge] Add tests covering trans_default_domain with dynamic expressions
#59116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but the PR is against the |
bc27721 to
6262a62
Compare
|
@xabbuh I fixed this. |
trans_default_domain with dynamic expressionstrans_default_domain with dynamic expressions
nicolas-grekas
approved these changes
Dec 7, 2024
|
Thank you @stof. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests covering the usage of
{% trans_default_domain %}with dynamic expressions (which we broke in 7.2.0 and fixed in #59059, which those tests would have caught).I'm adding those tests in 6.4 to increase test coverage on all versions, given that the test does not require changes anyway when upmerging.
#SymfonyHackday