8000 [Console] Use `assertSame` for input tests by theofidry · Pull Request #58455 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Use assertSame for input tests #58455

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2024
Merged

[Console] Use assertSame for input tests #58455

merged 1 commit into from
Oct 4, 2024

Conversation

theofidry
Copy link
Contributor
Q A
Branch? 7.2
Bug fix? no (test refactor)
New feature? no
Deprecations? no
Issues None
License MIT

This is a test refactor hence I am targeting 7.2 to avoid propagating noise. I originally intended to do it as part of #57598 as per @OskarStark comment but it turns out there is a few side effects so I preferred a dedicated PR to avoid confusion.

@theofidry theofidry requested a review from chalasr as a code owner October 4, 2024 09:03
@carsonbot carsonbot added this to the 7.2 milestone Oct 4, 2024
OskarStark
OskarStark approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor
@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@OskarStark OskarStark requested a review from xabbuh October 4, 2024 09:33
@OskarStark OskarStark changed the title [Console] Use assertSame for input tests [Console] Use assertSame for input tests Oct 4, 2024
@nicolas-grekas
Copy link
Member

Thank you @theofidry.

@nicolas-grekas nicolas-grekas merged commit 590f629 into symfony:7.2 Oct 4, 2024
10 checks passed
@theofidry theofidry deleted the test/console-assert-equals branch October 8, 2024 21:59
@stof stof mentioned this pull request Dec 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Console Status: Needs Review
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
4 participants
@theofidry @nicolas-grekas @OskarStark @carsonbot
0