[FrameworkBundle] [Console] added format parameter to ContainerDebugCommand #5740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the output from the ContainerDebugCommand easier to parse, this patch adds a `format` parameter to the command which defaults to `plain` (dumps the services like before). An additional `json` format is implemented to dump the container info in json.
| } | ||
| } | ||
|
|
||
| protected function outputServices(OutputInterface $output, $serviceIds, $showPrivate = false) | ||
| protected function outputServices(OutputInterface $output, $serviceIds, $showPrivate, $format = 'plain') |
There was a problem hiding this comment.
why removing the default value for $showPrivate ?
There was a problem hiding this comment.
good catch, thanks!
|
I would like to come up with some standardization here as we already have a few commands that also support outputting in a different format (for instance the list command that can dump command in XML). |
7 tasks
|
Closing in favor of #7454 |
fabpot
added a commit
that referenced
this pull request
Apr 23, 2013
This PR was squashed before being merged into the master branch (closes #7454). Discussion ---------- [Console] application/command as text/xml/whatever decoupling This PR removes description generation from `Command`, `Application` and `InputDefinition` classes and delegate it to specialized descriptor classes, making it dead simple to add new output formats. **Maybe this could include other commands, like `router:debug` or `container:debug` (see #5740)?** - [x] Add a `DescriptorProvider` which uses `DescriptorInterface` objects to describe things. - [x] Add `txt` descriptors. - [x] Add `xml` descriptors. - [x] Add `json` descriptors. - [x] Add `md` descriptors. - [x] Remove obsolete methods. - [x] Repair tests. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6339 Commits ------- 51512e6 [Console] application/command as text/xml/whatever decoupling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: [no]
Feature addition: [yes]
Backwards compatibility break: [no]
Symfony2 tests pass: [yes]
To make the output from the
ContainerDebugCommandeasier to parse, thispatch adds a
formatparameter to the command which defaults toplain(dumps the services like before). An additionaljsonformatis implemented to dump the container info in json.