8000 [Console] Allow to override the command used to execute the application during autocompletion by tucksaun · Pull Request #57371 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Allow to override the command used to execute the application during autocompletion #57371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Console] Allow to override the command used to execute the application during autocompletion #57371

wants to merge 1 commit into from

Conversation

tucksaun
Copy link
Contributor
@tucksaun tucksaun commented Jun 11, 2024 •
edited
Loading
Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues
License MIT

Relates to symfony-cli/console#11

When running Symfony CLI autocompletion, we will forward symfony console autocompletion to the application autocompletion shell helper.
But we need to be allowed to define how to run the console for two reasons:

  1. Ensure the console autocompletion uses symfony console under the hood to ensure the proper environment is used (PHP versions, extensions, etc)
  2. Make sure the autocompletion is able to run properly (otherwise the autocompletion magics will make it think the binary to run is only console instead of bin/console)

@tucksaun tucksaun requested a review from chalasr as a code owner June 11, 2024 15:35
@carsonbot carsonbot added this to the 7.2 milestone Jun 11, 2024
@carsonbot

This comment has been minimized.

Sign in to view
@tucksaun tucksaun force-pushed the sf-cli-autocomplete branch from e1b4638 to fb9d804 Compare June 14, 2024 10:54
@tucksaun tucksaun mentioned this pull request Jul 1, 2024
Merged
@tucksaun
Copy link
Contributor Author

Closing in favor or symfony-cli/symfony-cli#493

@tucksaun tucksaun closed this Jul 16, 2024
@tucksaun tucksaun deleted the sf-cli-autocomplete branch July 16, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Console Feature Status: Needs Review
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
2 participants
@tucksaun @carsonbot
0