[HttpClient] Fix cURL default options for PHP 8.4 #54830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
see https://github.com/symfony/symfony/actions/runs/8936565926/job/24547155340?pr=54832#step:8:2947 for how it looks like without these changes |
xabbuh
approved these changes
May 3, 2024
derrabus
approved these changes
May 3, 2024
|
Thank you @alexandre-daubois. |
This was referenced May 7, 2024
nicolas-grekas
added a commit
that referenced
this pull request
May 13, 2024
…-daubois) This PR was merged into the 5.4 branch. Discussion ---------- [HttpClient] Revert fixing curl default options | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Reverts #54830 because php/php-src#14165 got merged and fixes the unintentional BC break. (CI still red but should go to green when new nightlies are built) Commits ------- 365f7b4 [HttpClient] Revert fixing curl default options
Merged
This was referenced Jun 2, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.4 brings a change in ext/curl (php/php-src#13291) that requires
CurlResponseto be updated. Curl callbacks cannot be set to null anymore and requires real callable.Here is (one of) the CI error it fixes: